cmccabe commented on code in PR #14838: URL: https://github.com/apache/kafka/pull/14838#discussion_r1416342392
########## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ########## @@ -354,6 +357,25 @@ public ControllerResult<BrokerRegistrationReply> registerBroker( throw new BrokerIdNotRegisteredException("Controller is in pre-migration mode and cannot register KRaft " + "brokers until the metadata migration is complete."); } + + if (featureControl.metadataVersion().isDirectoryAssignmentSupported()) { + Set<Uuid> set = new HashSet<>(request.logDirs()); + if (set.stream().anyMatch(DirectoryId::reserved)) { + throw new InvalidRequestException("Reserved directory ID in request"); + } + if (set.size() != request.logDirs().size()) { + throw new InvalidRequestException("Duplicate directory ID in request"); + } + for (BrokerRegistration registration : brokerRegistrations().values()) { Review Comment: > Also, we shouldn't be checking the previous registration for this specific broker ID... it would be quite normal to re-register broker ID X with the same set of directories it had last time we registered it This might be what's causing the test failures btw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org