cmccabe commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1416317197
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -354,6 +357,25 @@ public ControllerResult<BrokerRegistrationReply>
registerBroker(
throw new BrokerIdNotRegisteredException("Controller is in
pre-migration mode and cannot register KRaft " +
"brokers until the metadata migration is complete.");
}
+
+ if (featureControl.metadataVersion().isDirectoryAssignmentSupported())
{
Review Comment:
It should not be legal to send an empty `logDirs` array when metadataVersion
>= 3.7-IV2
Since setting that MV on the controller requires that all the brokers
support it.
It is, of course, OK to send logDirs when MV < 3.7-IV2. They will be ignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
