cmccabe commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1416324308
##########
metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java:
##########
@@ -272,8 +274,17 @@ public void testRegistrationWithIncorrectClusterId() {
(short) 1));
}
+ private static Stream<Arguments> metadataVersions() {
+ return Stream.of(
+ MetadataVersion.IBP_3_3_IV2,
+ MetadataVersion.IBP_3_3_IV3,
+ MetadataVersion.LATEST_PRODUCTION,
Review Comment:
I feel like we should explicitly include `IBP_3_7_IV2` here rather than
`LATEST_PRODUCTION`. After all, that is the first JBOD version so it's worth
testing specifically, even after `LATEST_PRODUCTION` marches on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
