philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1419342099
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -194,11 +189,11 @@ static void runAtClose(final Collection<Optional<?
extends RequestManager>> requ
// Poll to ensure that request has been written to the socket. Wait
until either the timer has expired or until
// all requests have received a response.
- do {
+ while (timer.notExpired() &&
!requestFutures.stream().allMatch(Future::isDone)) {
Review Comment:
if the close timer has expired, should we proceed with closing without
sending the request? I'm undecided on this. @kirktrue wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
