philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1419685035
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##########
@@ -82,6 +82,7 @@ public PollResult poll(long currentTimeMs) {
*/
@Override
public PollResult pollOnClose() {
+ // TODO: move the logic to poll to handle signal close
Review Comment:
I added a method signalClose() to the interface. I wonder if we should keep
letting the network thread poll the network client as usual, until we actually
invoke close. This means, close will do very little but check if there are any
pending requests.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##########
@@ -82,6 +82,7 @@ public PollResult poll(long currentTimeMs) {
*/
@Override
public PollResult pollOnClose() {
+ // TODO: move the logic to poll to handle signal close
Review Comment:
@kirktrue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
