philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1419688648


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java:
##########
@@ -315,7 +315,8 @@ public void testFetcherCloseClosesFetchSessionsInBroker() {
         // the close() method with a Timer will NOT send out the close session 
requests on close. The network
         // I/O logic is handled inside ConsumerNetworkThread.runAtClose, so we 
need to run that logic here.
         ConsumerNetworkThread.runAtClose(singletonList(Optional.of(fetcher)), 
networkClientDelegate, timer);
-
+        // the network is polled during the last state of clean up.
+        networkClientDelegate.poll(time.timer(1));

Review Comment:
   cc @kirktrue 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to