dajac commented on code in PR #14848:
URL: https://github.com/apache/kafka/pull/14848#discussion_r1425483590
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java:
##########
@@ -16,57 +16,50 @@
*/
package org.apache.kafka.coordinator.group.metrics;
-import com.yammer.metrics.core.Gauge;
-import com.yammer.metrics.core.MetricName;
import com.yammer.metrics.core.MetricsRegistry;
import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.metrics.Gauge;
import org.apache.kafka.common.metrics.Metrics;
import org.apache.kafka.common.metrics.Sensor;
import org.apache.kafka.common.metrics.stats.Meter;
import org.apache.kafka.common.utils.Utils;
+import org.apache.kafka.coordinator.group.Group;
+import org.apache.kafka.coordinator.group.consumer.ConsumerGroup;
+import org.apache.kafka.coordinator.group.generic.GenericGroupState;
import org.apache.kafka.server.metrics.KafkaYammerMetrics;
import org.apache.kafka.timeline.SnapshotRegistry;
import java.util.Arrays;
import java.util.Collections;
-import java.util.HashMap;
import java.util.Map;
import java.util.Objects;
-import java.util.concurrent.atomic.AtomicLong;
+import java.util.concurrent.ConcurrentHashMap;
/**
* These are the metrics which are managed by the {@link
org.apache.kafka.coordinator.group.GroupMetadataManager} class.
* They generally pertain to aspects of group management, such as the number
of groups in different states.
*/
public class GroupCoordinatorMetrics extends CoordinatorMetrics implements
AutoCloseable {
+
public static final String METRICS_GROUP = "group-coordinator-metrics";
- public final static MetricName NUM_OFFSETS = getMetricName(
+ public final static com.yammer.metrics.core.MetricName NUM_OFFSETS =
getMetricName(
"GroupMetadataManager", "NumOffsets");
- public final static MetricName NUM_GENERIC_GROUPS = getMetricName(
- "GroupMetadataManager", "NumGroups");
Review Comment:
Where is this one now? We must keep all the old metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
