dajac commented on code in PR #14848:
URL: https://github.com/apache/kafka/pull/14848#discussion_r1426788188
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java:
##########
@@ -281,100 +297,93 @@ public void onUpdateLastCommittedOffset(TopicPartition
tp, long offset) {
}
}
- public static MetricName getMetricName(String type, String name) {
+ public static com.yammer.metrics.core.MetricName getMetricName(String
type, String name) {
return getMetricName("kafka.coordinator.group", type, name);
}
private void registerGauges() {
- registry.newGauge(NUM_OFFSETS, new Gauge<Long>() {
+ registry.newGauge(NUM_OFFSETS, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
return numOffsets();
}
Review Comment:
just to be clear, i was wondering whether the following would work:
```
registry.newGauge(NUM_OFFSETS, () -> numOffsets());
```
Does it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
