dajac commented on code in PR #14848:
URL: https://github.com/apache/kafka/pull/14848#discussion_r1425599818
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java:
##########
@@ -174,75 +151,91 @@ public GroupCoordinatorMetrics(MetricsRegistry registry,
Metrics metrics) {
));
}
- public Long numOffsets() {
- return shards.values().stream().mapToLong(shard ->
shard.localGaugeValue(NUM_OFFSETS)).sum();
+ private Long numOffsets() {
+ return
shards.values().stream().mapToLong(GroupCoordinatorMetricsShard::numOffsets).sum();
}
- public Long numGenericGroups() {
- return shards.values().stream().mapToLong(shard ->
shard.localGaugeValue(NUM_GENERIC_GROUPS)).sum();
+ private Long numGenericGroups() {
+ return shards.values().stream().mapToLong(shard ->
shard.numGenericGroups(null)).sum();
Review Comment:
nit: It may be better to add an overload without argument instead of passing
`null`.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java:
##########
@@ -174,75 +151,91 @@ public GroupCoordinatorMetrics(MetricsRegistry registry,
Metrics metrics) {
));
}
- public Long numOffsets() {
- return shards.values().stream().mapToLong(shard ->
shard.localGaugeValue(NUM_OFFSETS)).sum();
+ private Long numOffsets() {
+ return
shards.values().stream().mapToLong(GroupCoordinatorMetricsShard::numOffsets).sum();
}
- public Long numGenericGroups() {
- return shards.values().stream().mapToLong(shard ->
shard.localGaugeValue(NUM_GENERIC_GROUPS)).sum();
+ private Long numGenericGroups() {
+ return shards.values().stream().mapToLong(shard ->
shard.numGenericGroups(null)).sum();
}
- public Long numGenericGroupsPreparingRebalanceCount() {
- return NUM_GENERIC_GROUPS_PREPARING_REBALANCE_COUNTER.get();
+ private Long numGenericGroupsPreparingRebalance() {
+ return shards.values().stream().mapToLong(shard ->
shard.numGenericGroups(GenericGroupState.PREPARING_REBALANCE)).sum();
}
- public Long numGenericGroupsCompletingRebalanceCount() {
- return NUM_GENERIC_GROUPS_COMPLETING_REBALANCE_COUNTER.get();
+ private Long numGenericGroupsCompletingRebalance() {
+ return shards.values().stream().mapToLong(shard ->
shard.numGenericGroups(GenericGroupState.COMPLETING_REBALANCE)).sum();
}
- public Long numGenericGroupsStableCount() {
- return NUM_GENERIC_GROUPS_STABLE_COUNTER.get();
+ private Long numGenericGroupsStable() {
+ return shards.values().stream().mapToLong(shard ->
shard.numGenericGroups(GenericGroupState.STABLE)).sum();
}
- public Long numGenericGroupsDeadCount() {
- return NUM_GENERIC_GROUPS_DEAD_COUNTER.get();
+ private Long numGenericGroupsDead() {
+ return shards.values().stream().mapToLong(shard ->
shard.numGenericGroups(GenericGroupState.DEAD)).sum();
}
- public Long numGenericGroupsEmptyCount() {
- return NUM_GENERIC_GROUPS_EMPTY_COUNTER.get();
+ private Long numGenericGroupsEmpty() {
+ return shards.values().stream().mapToLong(shard ->
shard.numGenericGroups(GenericGroupState.EMPTY)).sum();
}
- public long numConsumerGroups() {
- return shards.values().stream().mapToLong(shard ->
shard.localGaugeValue(NUM_CONSUMER_GROUPS)).sum();
+ private long numConsumerGroups() {
+ return shards.values().stream().mapToLong(shard ->
shard.numConsumerGroups(null)).sum();
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
