philipnee commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1431509274


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -184,7 +184,9 @@ public NetworkClientDelegate.PollResult poll(long 
currentTimeMs) {
             return NetworkClientDelegate.PollResult.EMPTY;
         }
         pollTimer.update(currentTimeMs);
-        if (pollTimer.isExpired()) {
+        // If the poll timer expires during reconciliation, we need to wait 
till the reconciliation completes before
+        // sending another leave group.

Review Comment:
   if the member is reconciling its assignment, we need to wait for the process 
to finish before revoking all assignments, then leave the group.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to