cadonna commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1431561378
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -672,7 +672,11 @@ public void onHeartbeatRequestSent() {
MemberState state = state();
if (isStaled()) {
log.debug("Member {} is staled and is therefore leaving the group.
It will rejoin upon the next poll.", memberEpoch);
- transitionToJoining();
+ // clear the current assignment and subscription, and trigger
rebalance listener on the next poll
+
invokeOnPartitionsRevokedCallback(subscriptions.assignedPartitions()).whenComplete((r,
e) -> {
Review Comment:
Isn't revocation something that the broker tells the member to because of
rebalancing? In this case it is the member that decides to leave the group
because it exceeded the poll interval. It is similar to close. I do not think
we revoke partitions in close, do we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
