dajac commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433900022


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##########
@@ -266,6 +267,28 @@ CompletableFuture<OffsetDeleteResponseData> deleteOffsets(
         BufferSupplier bufferSupplier
     );
 
+    /**
+     * Complete a transaction. This is called when the WriteTxnMarkers API is 
called

Review Comment:
   That makes sense. I also added a check in 
`GroupCoordinatorService.completeTransaction` to fail if another partition is 
received as it is not expected. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to