jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1434215098
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/InMemoryPartitionWriter.java:
##########
@@ -102,6 +241,31 @@ public long append(
}
}
+ @Override
+ public long appendEndTransactionMarker(
+ TopicPartition tp,
+ long producerId,
+ short producerEpoch,
+ int coordinatorEpoch,
+ TransactionResult result
+ ) throws KafkaException {
+ PartitionState state = partitionState(tp);
+ state.lock.lock();
+ try {
+ state.entries.add(new LogControl(
+ producerId,
+ producerEpoch,
+ coordinatorEpoch,
+ result
+ ));
+ state.endOffset += 1;
+ if (autoCommit) commit(tp, state.endOffset);
Review Comment:
Is this like acks = 0? I wasn't aware of when this was used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
