dajac commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1434220316


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/InMemoryPartitionWriter.java:
##########
@@ -102,6 +241,31 @@ public long append(
         }
     }
 
+    @Override
+    public long appendEndTransactionMarker(
+        TopicPartition tp,
+        long producerId,
+        short producerEpoch,
+        int coordinatorEpoch,
+        TransactionResult result
+    ) throws KafkaException {
+        PartitionState state = partitionState(tp);
+        state.lock.lock();
+        try {
+            state.entries.add(new LogControl(
+                producerId,
+                producerEpoch,
+                coordinatorEpoch,
+                result
+            ));
+            state.endOffset += 1;
+            if (autoCommit) commit(tp, state.endOffset);

Review Comment:
   No. It is more like having a partition with a single replica so the HWM 
advances directly. Keep in mind that this is designed for being used in tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to