jolshan commented on code in PR #15155:
URL: https://github.com/apache/kafka/pull/15155#discussion_r1446773736
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -195,6 +196,11 @@ public OffsetMetadataManager build() {
*/
private final TimelineHashMap<Long, Offsets> pendingTransactionalOffsets;
+ /**
+ * The open transactions (producer ids) keyed by group.
+ */
+ private final TimelineHashMap<String, TimelineHashSet<Long>>
openTransactionsByGroup;
Review Comment:
just for my understanding though -- for every producer ID for a group we
return, we will have an offset in pendingTransactionalOffsets, and every
producer ID in pendingTransactionalOffsets will have its group in
openTransactionsByGroup.
I can't imagine we would have a case where something is in one map but not
the other. (I can imagine that the group is not there at all or the topic
partition is not there though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
