jolshan commented on code in PR #15155: URL: https://github.com/apache/kafka/pull/15155#discussion_r1446774595
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ########## @@ -668,6 +697,8 @@ public OffsetFetchResponseData.OffsetFetchResponseGroup fetchOffsets( OffsetFetchRequestData.OffsetFetchRequestGroup request, long lastCommittedOffset ) throws ApiException { + final boolean requireStable = lastCommittedOffset == Long.MAX_VALUE; Review Comment: is it the case that when we query stable offsets we always have the long max value for lastCommittedOffset? Or in other words, we can't query a specific offset when we require stable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org