jolshan commented on code in PR #15155:
URL: https://github.com/apache/kafka/pull/15155#discussion_r1447907424


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -195,6 +196,11 @@ public OffsetMetadataManager build() {
      */
     private final TimelineHashMap<Long, Offsets> pendingTransactionalOffsets;
 
+    /**
+     * The open transactions (producer ids) keyed by group.
+     */
+    private final TimelineHashMap<String, TimelineHashSet<Long>> 
openTransactionsByGroup;

Review Comment:
   Sorry -- I left a lot of words here. Is there a time where we take advantage 
of the data structure? Ie using the epoch/rolling back? I didn't see any in 
this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to