dajac commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1467651194
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -360,14 +334,13 @@ public CompletableFuture<JoinGroupResponseData> joinGroup(
Duration.ofMillis(config.offsetCommitTimeoutMs),
coordinator -> coordinator.classicGroupJoin(context, request,
responseFuture)
).exceptionally(exception -> {
- if (!(exception instanceof KafkaException)) {
Review Comment:
It will be handled by
https://github.com/apache/kafka/pull/15196/files#diff-ea6dfd70c68aa99b5dc43eecadb8f3b555cb5a54162cd681bcc1477fd936913dR1080.
The non KafkaExceptions are converted to UNKNOWN_SERVER_ERROR and are logged.
The change relies on the existing tests. The overall error handling did not
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
