dajac commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1467662146
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -595,27 +568,17 @@ public
CompletableFuture<List<ConsumerGroupDescribeResponseData.DescribedGroup>>
"consumer-group-describe",
topicPartition,
(coordinator, lastCommittedOffset) ->
coordinator.consumerGroupDescribe(groupIds, lastCommittedOffset)
- ).exceptionally(exception -> {
- if (!(exception instanceof KafkaException)) {
- log.error("ConsumerGroupDescribe request {} hit an
unexpected exception: {}.",
- groupList, exception.getMessage());
- }
-
- return
ConsumerGroupDescribeRequest.getErrorDescribedGroupList(
- groupList,
- Errors.forException(exception)
- );
- });
+ ).exceptionally(exception -> handleOperationException(
+ "ConsumerGroupDescribe",
+ groupList,
+ exception,
+ (error, __) ->
ConsumerGroupDescribeRequest.getErrorDescribedGroupList(groupList, error)
+ ));
futures.add(future);
});
- final CompletableFuture<Void> allFutures =
CompletableFuture.allOf(futures.toArray(new CompletableFuture[0]));
Review Comment:
Yeah. Nice, isn't it? ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
