dajac commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1467652655
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -444,21 +416,21 @@ public CompletableFuture<HeartbeatResponseData> heartbeat(
return runtime.scheduleReadOperation("classic-group-heartbeat",
topicPartitionFor(request.groupId()),
(coordinator, __) -> coordinator.classicGroupHeartbeat(context,
request)
- ).exceptionally(exception -> {
- if (!(exception instanceof KafkaException)) {
- log.error("Heartbeat request {} hit an unexpected exception:
{}",
- request, exception.getMessage());
- }
-
- if (exception instanceof CoordinatorLoadInProgressException) {
- // The group is still loading, so blindly respond
- return new HeartbeatResponseData()
- .setErrorCode(Errors.NONE.code());
+ ).exceptionally(exception -> handleOperationException(
+ "Heartbeat",
Review Comment:
Added a not to the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
