dajac commented on code in PR #15196:
URL: https://github.com/apache/kafka/pull/15196#discussion_r1467996373
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -360,14 +334,13 @@ public CompletableFuture<JoinGroupResponseData> joinGroup(
Duration.ofMillis(config.offsetCommitTimeoutMs),
coordinator -> coordinator.classicGroupJoin(context, request,
responseFuture)
).exceptionally(exception -> {
- if (!(exception instanceof KafkaException)) {
Review Comment:
Sorry, I did not get your point initially. The errors for those APIs are
also converted but they are within ´classicGroupJoin’ based on the same scheme.
So doing it here does not hurt. As a follow up, I’d like to remove the
translation there in order to have it centralized here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
