mjsax commented on code in PR #14360:
URL: https://github.com/apache/kafka/pull/14360#discussion_r1473419962
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -482,7 +482,8 @@ public class StreamsConfig extends AbstractConfig {
public static final String BUILT_IN_METRICS_VERSION_CONFIG =
"built.in.metrics.version";
private static final String BUILT_IN_METRICS_VERSION_DOC = "Version of the
built-in metrics to use.";
- /** {@code cache.max.bytes.buffering} */
+ /** {@code cache.max.bytes.buffering}
+ * @deprecated since 3.4.0 Use cache.max.bytes instead with the cache.size
metric at the DEBUG level. */
Review Comment:
```suggestion
* @deprecated since 3.4.0 Use {@link #CACHE_MAX_BYTES_CONFIG
"cache.max.bytes"} instead. */
```
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -537,14 +538,16 @@ public class StreamsConfig extends AbstractConfig {
public static final String ROCKS_DB = "rocksDB";
public static final String IN_MEMORY = "in_memory";
- /** {@code default.windowed.key.serde.inner} */
+ /** {@code default.windowed.key.serde.inner
+ * @deprecated since 3.0.0 Use windowed.inner.class.serde instead.} */
Review Comment:
```suggestion
* @deprecated since 3.0.0 Use {@link #WINDOWED_INNER_CLASS_SERDE
"windowed.inner.class.serde"} instead.} */
```
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -482,7 +482,8 @@ public class StreamsConfig extends AbstractConfig {
public static final String BUILT_IN_METRICS_VERSION_CONFIG =
"built.in.metrics.version";
private static final String BUILT_IN_METRICS_VERSION_DOC = "Version of the
built-in metrics to use.";
- /** {@code cache.max.bytes.buffering} */
+ /** {@code cache.max.bytes.buffering}
+ * @deprecated since 3.4.0 Use cache.max.bytes instead with the cache.size
metric at the DEBUG level. */
Review Comment:
Not sure if I understand the reference to `cache.size` metric? Can you
elaborate?
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -537,14 +538,16 @@ public class StreamsConfig extends AbstractConfig {
public static final String ROCKS_DB = "rocksDB";
public static final String IN_MEMORY = "in_memory";
- /** {@code default.windowed.key.serde.inner} */
+ /** {@code default.windowed.key.serde.inner
+ * @deprecated since 3.0.0 Use windowed.inner.class.serde instead.} */
@SuppressWarnings("WeakerAccess")
@Deprecated
public static final String DEFAULT_WINDOWED_KEY_SERDE_INNER_CLASS =
"default.windowed.key.serde.inner";
private static final String DEFAULT_WINDOWED_KEY_SERDE_INNER_CLASS_DOC =
"Default serializer / deserializer for the inner class of a windowed key. Must
implement the " +
"<code>org.apache.kafka.common.serialization.Serde</code> interface.";
- /** {@code default.windowed.value.serde.inner} */
+ /** {@code default.windowed.value.serde.inner
+ * @deprecated since 3.0.0 Use windowed.inner.class.serde instead.} */
Review Comment:
as above
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -620,7 +623,8 @@ public class StreamsConfig extends AbstractConfig {
@SuppressWarnings("WeakerAccess")
public static final String METRICS_SAMPLE_WINDOW_MS_CONFIG =
CommonClientConfigs.METRICS_SAMPLE_WINDOW_MS_CONFIG;
- /** {@code auto.include.jmx.reporter} */
+ /** {@code auto.include.jmx.reporter
+ * @deprecated and will removed in 4.0.0 Use
org.apache.kafka.common.metrics.JmxReporter in metric.reporters instead.} */
Review Comment:
as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
