mjsax commented on code in PR #14360:
URL: https://github.com/apache/kafka/pull/14360#discussion_r1483595167
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -1010,6 +1016,18 @@ <h4><a class="toc-backref"
href="#id31">topology.optimization</a><a class="heade
</p>
</div></blockquote>
</div>
+ <div class="section" id="windowed.inner.class.serde">
+ <h4><a class="toc-backref" href="#id31">windowed.inner.class.serde</a><a
class="headerlink" href="#windowed.inner.class.serde" title="Permalink to this
headline"></a></h4>
+ <blockquote>
+ <div>
+ <p>
+ Serde for the inner class of a windowed record. Must implement the
org.apache.kafka.common.serialization.Serde interface.
+ </p>
+ <p>
+ Note that setting this config in KafkaStreams application would
result in an error as it is meant to be used only from Plain consumer client.
Review Comment:
> Are you proposing to move it to ClientConfig or just not .define it in
any class? In the end, we added it via KIP and would need to move/remove it via
KIP, and I'm not sure it's worth doing a KIP over. We can just leave it out of
the Streams config docs
Yes, the idea was to maybe do a small KIP and remove it from `StreamsConfig`
as it does not belong there. If Lucia is interested in doing it -- I agree it's
not super critical, and just removing from the docs is also fine with me.
About `window.inner.serde.class` it is indeed used by Kafka Streams itself
(cf `TimeWindowedSerializer` and others). If one would set default serde to
`TimeWindowedSerializer` it would be used, so I think it's ok to have it in the
docs, and also correct to have it as `StreamsConfig` registered via `define()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
