ableegoldman commented on code in PR #14360: URL: https://github.com/apache/kafka/pull/14360#discussion_r1479177626
########## docs/streams/developer-guide/config-streams.html: ########## @@ -1010,6 +1016,18 @@ <h4><a class="toc-backref" href="#id31">topology.optimization</a><a class="heade </p> </div></blockquote> </div> + <div class="section" id="windowed.inner.class.serde"> + <h4><a class="toc-backref" href="#id31">windowed.inner.class.serde</a><a class="headerlink" href="#windowed.inner.class.serde" title="Permalink to this headline"></a></h4> + <blockquote> + <div> + <p> + Serde for the inner class of a windowed record. Must implement the org.apache.kafka.common.serialization.Serde interface. + </p> + <p> + Note that setting this config in KafkaStreams application would result in an error as it is meant to be used only from Plain consumer client. Review Comment: I guess `window.size.ms` is just in a weird place somewhere between a client config and a streams config. Given that it's not for use in an actual Kafka Streams application, it makes sense to me that we should not include it in the Streams config docs. Are you proposing to move it to ClientConfig or just not `.define` it in any class? In the end, we added it via KIP and would need to move/remove it via KIP, and I'm not sure it's worth doing a KIP over. We can just leave it out of the Streams config docs Also -- this applies to both `window.size.ms` and `window.inner.serde.class`, no? I don't understand this bit: > window.inner.serde.class is a KS config and should just be documented in the regular way. They are essentially the same kind of config, they just refer to the two different parameters of a windowed serde. If `window.size.ms` is not a KS config, then neither is `window.inner.serde.class` -- and vice versa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org