yyu1993 commented on code in PR #15384:
URL: https://github.com/apache/kafka/pull/15384#discussion_r1496339739
##########
tools/src/test/java/org/apache/kafka/tools/TransactionsCommandTest.java:
##########
@@ -187,14 +187,25 @@ private void testDescribeProducers(
assertEquals(expectedRows, new HashSet<>(table.subList(1,
table.size())));
}
- @Test
- public void testListTransactions() throws Exception {
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ public void testListTransactions(boolean hasDurationFilter) throws
Exception {
String[] args = new String[] {
"--bootstrap-server",
"localhost:9092",
"list"
};
+ if (hasDurationFilter) {
+ args = new String[] {
+ "--bootstrap-server",
+ "localhost:9092",
+ "list",
+ "--duration-filter",
+ Long.toString(Long.MAX_VALUE)
Review Comment:
This just tests the cli cmd parsing parameters correctly. It will not call
actual list transaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
