yyu1993 commented on code in PR #15384:
URL: https://github.com/apache/kafka/pull/15384#discussion_r1496360067


##########
clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsOptions.java:
##########
@@ -81,11 +87,16 @@ public Set<Long> filteredProducerIds() {
         return filteredProducerIds;
     }
 
+    public long getDurationFilter() {
+        return durationFilter;
+    }
+
     @Override
     public String toString() {
         return "ListTransactionsOptions(" +
             "filteredStates=" + filteredStates +
             ", filteredProducerIds=" + filteredProducerIds +
+            ", durationFilter=" + durationFilter +

Review Comment:
   updated in 
[8bfc13a](https://github.com/apache/kafka/pull/15384/commits/8bfc13ae7551ecbc6df2502a4904892a4d1402b7)



##########
clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsOptions.java:
##########
@@ -81,11 +87,16 @@ public Set<Long> filteredProducerIds() {
         return filteredProducerIds;
     }
 
+    public long getDurationFilter() {

Review Comment:
   updated in 
[8bfc13a](https://github.com/apache/kafka/pull/15384/commits/8bfc13ae7551ecbc6df2502a4904892a4d1402b7)



##########
clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsOptions.java:
##########
@@ -61,6 +62,11 @@ public ListTransactionsOptions 
filterProducerIds(Collection<Long> producerIdFilt
         return this;
     }
 
+    public ListTransactionsOptions durationFilter(long durationMs) {

Review Comment:
   updated in 
[8bfc13a](https://github.com/apache/kafka/pull/15384/commits/8bfc13ae7551ecbc6df2502a4904892a4d1402b7)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to