brandboat commented on code in PR #15512:
URL: https://github.com/apache/kafka/pull/15512#discussion_r1527189077


##########
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##########
@@ -850,7 +851,7 @@ public void testMetadataTimeoutWithMissingTopic(boolean 
isIdempotenceEnabled) th
         try {
             future.get();

Review Comment:
   Thanks for the detailed review ! :smiley: 
   
   Here's the revised version for a final check before I proceed with applying 
it.
   ```java
   try {
       assertInstanceOf(TimeoutException.class, 
assertThrows(ExecutionException.class, future::get).getCause());
   } finally {
       producer.close(Duration.ofMillis(0));
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to