brandboat commented on code in PR #15512:
URL: https://github.com/apache/kafka/pull/15512#discussion_r1530599572
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java:
##########
@@ -1037,7 +1038,7 @@ public void
testHeartbeatRequestWithFencedInstanceIdException() throws Interrupt
}
fail("Expected pollHeartbeat to raise fenced instance id exception
in 1 second");
} catch (RuntimeException exception) {
- assertTrue(exception instanceof FencedInstanceIdException);
+ assertInstanceOf(FencedInstanceIdException.class, exception);
Review Comment:
Huge thanks for the detailed view again ! :smiley:
> I have pushed a commit to rebase code and fix conflict. will merge it if
there is no connected failure.
You are so kind! Next time I'll try to fix the conflict faster...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
