brandboat commented on PR #15512: URL: https://github.com/apache/kafka/pull/15512#issuecomment-2002043253
gentle ping @chia7712, there is another case that could be replaced with assertIsntanceOf (in IntelliJ Find in files with regex `assertTrue\(\n?.*isInstance`) https://github.com/apache/kafka/blob/3f666026260472179c17ded967a8d9577107e1f0/clients/src/test/java/org/apache/kafka/test/TestUtils.java#L559 could be replaced with ``` assertInstanceOf(exceptionCauseClass, exception.getCause(), ``` should we include this one too ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
