chia7712 commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1549747480
##########
core/src/main/scala/kafka/server/KafkaBroker.scala:
##########
@@ -93,6 +93,7 @@ trait KafkaBroker extends Logging {
def startup(): Unit
def awaitShutdown(): Unit
def shutdown(): Unit
+ def shutdown(timeoutMs: Long): Unit
Review Comment:
How about using `Duration` instead of long type? Also, we can rename it from
`timeoutMs` to `timeout`
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -623,9 +623,12 @@ class BrokerServer(
}
}
- override def shutdown(): Unit = {
+ override def shutdown(): Unit = shutdown(TimeUnit.MINUTES.toMillis(5))
Review Comment:
How about adding default implementation to parent class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
