soarez commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1554541084
##########
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##########
@@ -260,9 +274,12 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
}
def killBroker(index: Int): Unit = {
Review Comment:
Oh I see. It was a mistake to remove `awaitShutdown`. I think we should
leave the behavior as is, I don't see any reason why the new `killBroker(idx,
timeout)` alternative shouldn't also call `awaitShutdown`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
