soarez commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1551132385
##########
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala:
##########
@@ -197,12 +198,11 @@ class ServerShutdownTest extends KafkaServerTestHarness {
verifyNonDaemonThreadsStatus()
}
- @Disabled
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
@ValueSource(strings = Array("kraft"))
def testCleanShutdownWithKRaftControllerUnavailable(quorum: String): Unit = {
Review Comment:
That's a good point. If the controller is unavailable, the shutdown can't
really be considered clean. However, I think it's better to just remove the
`Clean` word from the method, rather than replacing it with `Dirty`. It seems
cleaner and less confusing, as it might not be clear what "dirty" is referring
to. Please let me know if you disagree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
