chia7712 commented on code in PR #15569: URL: https://github.com/apache/kafka/pull/15569#discussion_r1561034133
########## server/src/main/java/org/apache/kafka/server/config/KafkaLogConfigs.java: ########## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.server.config; + +import org.apache.kafka.common.config.TopicConfig; +import static org.apache.kafka.server.config.ServerTopicConfigSynonyms.LOG_PREFIX; + +/** + * Common home for broker-side log configs which need to be accessible from the libraries shared + * between the broker and the multiple modules in Kafka. + * + * Note this is an internal API and subject to change without notice. + */ +public class KafkaLogConfigs { + public final static String NUM_PARTITIONS_CONFIG = "num.partitions"; + public static final int NUM_PARTITIONS_DEFAULT = 1; + public final static String NUM_PARTITIONS_DOC = "The default number of log partitions per topic"; + + public final static String LOG_DIRS_CONFIG = LOG_PREFIX + "dirs"; + public final static String LOG_DIR_CONFIG = LOG_PREFIX + "dir"; + public static final String LOG_DIR_DEFAULT = "/tmp/kafka-logs"; + public final static String LOG_DIR_DOC = "The directory in which the log data is kept (supplemental for " + LOG_DIRS_CONFIG + " property)"; Review Comment: Should we align the declaration style? I prefer the style: `static final` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
