OmniaGM commented on PR #15569: URL: https://github.com/apache/kafka/pull/15569#issuecomment-2059643602
> Let's just let Omnia decides which PR she prefers doing first. Then we can all review that PR, and once merged move onto the next one. This would avoid unnecessary churn as I expect she's getting tired of rebasing all of these PRs every day! Thanks @mimaison this is really thoughtful! breaking KafkaConfig out of core is one of the hardest cleanup specially if we want to move with smaller/medium PRs. So I don't see any other way than going through it. I think it might be better to take them in order so we can get them merged and the rebases can be easier. Let's merge https://github.com/apache/kafka/pull/15684 as - it is smaller - more contained than the log config - and group configs are more likely to change as part of KIP-848 and any of its followups which make the conflicts much harder and risker to get messed up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
