mimaison commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1569073857
##########
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##########
@@ -79,10 +80,10 @@ class ZkAdminManager(val config: KafkaConfig,
private val configHelper = new ConfigHelper(metadataCache, config, new
ZkConfigRepository(adminZkClient))
private val createTopicPolicy =
-
Option(config.getConfiguredInstance(KafkaConfig.CreateTopicPolicyClassNameProp,
classOf[CreateTopicPolicy]))
+ Option(config.getConfiguredInstance(ALTER_CONFIG_POLICY_CLASS_NAME_CONFIG,
classOf[CreateTopicPolicy]))
Review Comment:
This should be `CREATE_TOPIC_POLICY_CLASS_NAME_CONFIG`
##########
core/src/test/scala/unit/kafka/log/LogConfigTest.scala:
##########
@@ -399,18 +400,18 @@ class LogConfigTest {
}
}
- /* Verify that when the deprecated config
LogMessageTimestampDifferenceMaxMsProp has non default value the new configs
- * LogMessageTimestampBeforeMaxMsProp and LogMessageTimestampAfterMaxMsProp
are not changed from the default we are using
+ /* Verify that when the deprecated config
LOG_MESSAGE_TIMESTAMP_DIFFERENCE_MAX_MS_PROP has non default value the new
configs
Review Comment:
`LOG_MESSAGE_TIMESTAMP_DIFFERENCE_MAX_MS_PROP` has been renamed to
`LOG_MESSAGE_TIMESTAMP_BEFORE_MAX_MS_CONFIG`
Same below
##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -1152,12 +1151,12 @@ class KafkaConfigTest {
defaults.setProperty(KafkaConfig.BrokerIdProp, "1")
defaults.setProperty(KafkaConfig.ListenersProp,
"PLAINTEXT://127.0.0.1:1122")
defaults.setProperty(KafkaConfig.MaxConnectionsPerIpOverridesProp,
"127.0.0.1:2, 127.0.0.2:3")
- defaults.setProperty(KafkaConfig.LogDirProp, "/tmp1,/tmp2")
- defaults.setProperty(KafkaConfig.LogRollTimeHoursProp, "12")
- defaults.setProperty(KafkaConfig.LogRollTimeJitterHoursProp, "11")
- defaults.setProperty(KafkaConfig.LogRetentionTimeHoursProp, "10")
- //For LogFlushIntervalMsProp
- defaults.setProperty(KafkaConfig.LogFlushSchedulerIntervalMsProp, "123")
+ defaults.setProperty(KafkaLogConfigs.LOG_DIR_CONFIG, "/tmp1,/tmp2")
+ defaults.setProperty(KafkaLogConfigs.LOG_ROLL_TIME_HOURS_CONFIG, "12")
+ defaults.setProperty(KafkaLogConfigs.LOG_ROLL_TIME_JITTER_HOURS_CONFIG,
"11")
+ defaults.setProperty(KafkaLogConfigs.LOG_RETENTION_TIME_HOURS_CONFIG, "10")
+ //For LOG_FLUSH_INTERVAL_MS_PROP
Review Comment:
This has been renamed to `LOG_FLUSH_INTERVAL_MS_CONFIG`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
