gharris1727 commented on code in PR #15469:
URL: https://github.com/apache/kafka/pull/15469#discussion_r1568679258
##########
connect/api/src/main/java/org/apache/kafka/connect/data/Values.java:
##########
@@ -766,135 +852,23 @@ protected static boolean
canParseSingleTokenLiteral(Parser parser, boolean embed
protected static SchemaAndValue parse(Parser parser, boolean embedded)
throws NoSuchElementException {
Review Comment:
That's a cool idea, I think that makes a lot of sense when a bunch of these
static methods take a Parser argument anyway.
Since this is in the public API, I'll focus on moving some of the internal
methods to instance methods of a protected/package local Parser, and leave the
public static methods in Values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
