gharris1727 commented on code in PR #15469:
URL: https://github.com/apache/kafka/pull/15469#discussion_r1591616004
##########
connect/api/src/main/java/org/apache/kafka/connect/data/Values.java:
##########
@@ -177,7 +213,12 @@ public static Long convertToLong(Schema schema, Object
value) throws DataExcepti
* @throws DataException if the value could not be converted to a float
*/
public static Float convertToFloat(Schema schema, Object value) throws
DataException {
Review Comment:
I added tests to get the methods themselves up to 100% coverage, but the
overall class still is missing some coverage. Thanks for pointing this out, as
there were certainly some pretty obvious cases that weren't tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
