gharris1727 commented on code in PR #15469: URL: https://github.com/apache/kafka/pull/15469#discussion_r1592918790
########## connect/api/src/main/java/org/apache/kafka/connect/data/Values.java: ########## @@ -766,135 +852,23 @@ protected static boolean canParseSingleTokenLiteral(Parser parser, boolean embed protected static SchemaAndValue parse(Parser parser, boolean embedded) throws NoSuchElementException { Review Comment: I decided that pulling this class apart into standalone classes is possible, but a little bit risky compatibility-wise, and more complexity than I wanted to take on in this PR. I've moved the static methods accepting Parser to be instance methods of an inner class, so that they can still call into Values to do conversions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org