mimaison commented on code in PR #15469: URL: https://github.com/apache/kafka/pull/15469#discussion_r1598385955
########## connect/api/src/main/java/org/apache/kafka/connect/data/Values.java: ########## @@ -766,135 +852,23 @@ protected static boolean canParseSingleTokenLiteral(Parser parser, boolean embed protected static SchemaAndValue parse(Parser parser, boolean embedded) throws NoSuchElementException { Review Comment: The `Parser` class shows up in https://kafka.apache.org/37/javadoc/org/apache/kafka/connect/data/Values.Parser.html so not sure if we can make it private. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org