AndrewJSchofield commented on code in PR #15909:
URL: https://github.com/apache/kafka/pull/15909#discussion_r1596861973
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -255,11 +257,15 @@ public long maximumTimeToWait(long currentTimeMs) {
* member to {@link MemberState#JOINING}, so that it rejoins the group.
*/
public void resetPollTimer(final long pollMs) {
+ pollTimer.update(pollMs);
if (pollTimer.isExpired()) {
- logger.debug("Poll timer has been reset after it had expired");
+ logger.warn("Time between subsequent calls to poll() was longer
than the configured" +
+ "max.poll.interval.ms, exceeded by %s ms. This typically
implies that the " +
Review Comment:
`{}`?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -255,11 +257,15 @@ public long maximumTimeToWait(long currentTimeMs) {
* member to {@link MemberState#JOINING}, so that it rejoins the group.
*/
public void resetPollTimer(final long pollMs) {
+ pollTimer.update(pollMs);
if (pollTimer.isExpired()) {
Review Comment:
I would rather have a method added to `Timer` such as `long hasExpiredBy()`
so the check for expiration and the calculation of by how much is encapsulated
in the timer itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
