lianetm commented on code in PR #15909:
URL: https://github.com/apache/kafka/pull/15909#discussion_r1597219039
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -193,11 +193,8 @@ public NetworkClientDelegate.PollResult poll(long
currentTimeMs) {
}
pollTimer.update(currentTimeMs);
if (pollTimer.isExpired() && !membershipManager.isLeavingGroup()) {
- logger.warn("Consumer poll timeout has expired. This means the
time between " +
Review Comment:
Done, I did like the simplified log but totally agree with your points,
both. I've been myself pushing for avoiding changing the existing logs content
when possible because I've also heard about customers basing their apps on
them. Also agree about the more complete output on the case of not hitting the
next poll in a sensible time.
So left the log here unchanged (and simplified the other just to not repeat
ourselves on the 2 logs). So in the common case that we end up with the 2 log
lines, it's just a first one about the situation when it happens, and the 2nd
one with the approximate exceeded time when we have the most accurate info.
Makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
