lianetm commented on code in PR #15909:
URL: https://github.com/apache/kafka/pull/15909#discussion_r1597000322
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -255,11 +257,15 @@ public long maximumTimeToWait(long currentTimeMs) {
* member to {@link MemberState#JOINING}, so that it rejoins the group.
*/
public void resetPollTimer(final long pollMs) {
+ pollTimer.update(pollMs);
if (pollTimer.isExpired()) {
Review Comment:
agree, makes total sense, so moved the calculation to the timer, with an
`isExpiredBy`. Small twist to what I understand you were suggesting, I kept the
`isExpired` check, just to avoid having to deal with the logic of deducing if
the timer is expired based on the `isExpiredBy` on the HBManager. Seems better
to let the timer know the semantics of when it's considered expired (it does
consider >= for instance, so just avoiding to bring those semantics into the
HBManager). Makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
