prestona commented on code in PR #15910:
URL: https://github.com/apache/kafka/pull/15910#discussion_r1602244281


##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java:
##########
@@ -103,10 +113,11 @@ public void start(Map<String, String> props) {
         targetAdminClient = 
config.forwardingAdmin(config.targetAdminConfig("checkpoint-target-admin"));
         metrics = config.metrics();
         idleConsumerGroupsOffset = new HashMap<>();
-        checkpointsPerConsumerGroup = new HashMap<>();
+        Optional<Map<String, Map<TopicPartition, Checkpoint>>> checkpoints = 
readCheckpoints(config);

Review Comment:
   Thanks for the explanation, and suggestion. We'll take another look at 
reading the checkpoint topic asynchronously from the start() method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to