edoardocomar commented on code in PR #15910:
URL: https://github.com/apache/kafka/pull/15910#discussion_r1602265328
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##########
@@ -105,7 +106,13 @@ private KafkaBasedLog<byte[], byte[]>
createBackingStore(MirrorCheckpointConfig
/**
* Start the OffsetSyncStore, blocking until all previous Offset Syncs
have been read from backing storage.
*/
- public void start() {
+ public void start(boolean initializationMustReadToEnd) {
+ this.initializationMustReadToEnd = initializationMustReadToEnd;
+ if (initializationMustReadToEnd) {
+ log.warn("OffsetSyncStore initializationMustReadToEnd = {}",
initializationMustReadToEnd);
Review Comment:
I think that getting the fallback degraded behavior is not the normal case
and therefore I strongly prefer a warn here.
However here we do know the reason why we are getting this - so we should
explain that in the record handler as suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
