nizhikov commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1629598556
##########
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##########
@@ -29,19 +32,22 @@ public class QuorumInfo {
private final long highWatermark;
private final List<ReplicaState> voters;
private final List<ReplicaState> observers;
+ private final Map<Integer, Node> nodes;
Review Comment:
> It looks like we already store nodeId in Node object, and we don't need
the nodeId as key, right?
Correct. My first implementation was Set based. But, @cmccabe ask to
refactor to Map
See - https://github.com/apache/kafka/pull/16106#discussion_r1628472921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
