nizhikov commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1629645429


##########
core/src/test/scala/unit/kafka/server/DescribeQuorumRequestTest.scala:
##########
@@ -60,6 +60,7 @@ class DescribeQuorumRequestTest(cluster: ClusterInstance) {
       val response = connectAndReceive[DescribeQuorumResponse](request)
 
       assertEquals(Errors.NONE, Errors.forCode(response.data.errorCode))
+      assertEquals("", response.data.errorMessage)

Review Comment:
   `Readable#readString` returns empty string if length of string equals to 0.
   `DescribeQuorumResponseData#read` writes empty string to `errorMessage` for 
other version of RPC that not supports new field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to