showuon commented on code in PR #16106:
URL: https://github.com/apache/kafka/pull/16106#discussion_r1630612543
##########
core/src/test/scala/unit/kafka/server/DescribeQuorumRequestTest.scala:
##########
@@ -60,6 +60,7 @@ class DescribeQuorumRequestTest(cluster: ClusterInstance) {
val response = connectAndReceive[DescribeQuorumResponse](request)
assertEquals(Errors.NONE, Errors.forCode(response.data.errorCode))
+ assertEquals("", response.data.errorMessage)
Review Comment:
OK, thanks.
##########
raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java:
##########
@@ -44,25 +48,26 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
public class LeaderStateTest {
- private final int localId = 0;
- private final int epoch = 5;
+ private final Entry<Integer, VoterSet.VoterNode> localId = entry(0);
+ private final Entry<Integer, VoterSet.VoterNode> epoch = entry(5);
Review Comment:
Any update to this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
