lianetm commented on code in PR #16569: URL: https://github.com/apache/kafka/pull/16569#discussion_r1676141611
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ########## @@ -166,33 +167,13 @@ public void testMembershipManagerInitSupportsEmptyGroupInstanceId() { createMembershipManagerJoiningGroup(); } - @Test - public void testMembershipManagerRegistersForClusterMetadataUpdatesOnFirstJoin() { Review Comment: this is just small clean-up unrelated to this PR (but I found it while on it). This test does not apply anymore, and it passes only because it's not really testing what its name suggest. The `membershipMgr` did register for metadata updates at some point, but it stopped doing it the moment it was turned into a manager that is polled on a regular basis to trigger reconciliations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org