mjsax commented on code in PR #17321:
URL: https://github.com/apache/kafka/pull/17321#discussion_r1803841219
##########
tests/kafkatest/tests/streams/streams_cooperative_rebalance_upgrade_test.py:
##########
@@ -68,9 +67,8 @@ def __init__(self, test_context):
acks=1)
@cluster(num_nodes=8)
- @matrix(upgrade_from_version=streams_eager_rebalance_upgrade_versions)
- def test_upgrade_to_cooperative_rebalance(self, upgrade_from_version):
- self.zookeeper.start()
+ @matrix(upgrade_from_version=streams_eager_rebalance_upgrade_versions,
metadata_quorum=[quorum.combined_kraft])
Review Comment:
Given that each parameter has exactly on value, it seem we could remove them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
