bbejeck commented on code in PR #17321:
URL: https://github.com/apache/kafka/pull/17321#discussion_r1807052033
##########
tests/kafkatest/tests/streams/streams_cooperative_rebalance_upgrade_test.py:
##########
@@ -68,9 +67,8 @@ def __init__(self, test_context):
acks=1)
@cluster(num_nodes=8)
- @matrix(upgrade_from_version=streams_eager_rebalance_upgrade_versions)
- def test_upgrade_to_cooperative_rebalance(self, upgrade_from_version):
- self.zookeeper.start()
+ @matrix(upgrade_from_version=streams_eager_rebalance_upgrade_versions,
metadata_quorum=[quorum.combined_kraft])
Review Comment:
Right now the `metadata_quorum` in the `@matrix` annotation is required by
test_context in `quorum.py` to determine if its using ZK or KRaft (maybe it'll
pick it up from the parameter itself?) The `upgrade_from_version` points to an
array so it doesn't have one value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
